Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dungeonmap fix + rewrite #595

Merged
merged 6 commits into from
Mar 18, 2024
Merged

Dungeonmap fix + rewrite #595

merged 6 commits into from
Mar 18, 2024

Conversation

Julienraptor01
Copy link
Contributor

No description provided.

@AzureAaron AzureAaron added bug Something isn't working reviews needed This PR needs reviews wip This PR is a work in progress and removed reviews needed This PR needs reviews labels Mar 13, 2024
@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Mar 14, 2024
AzureAaron
AzureAaron requested changes Mar 15, 2024
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also must hide the map in boss, it isn't useful and takes up screen space.

src/main/java/de/hysky/skyblocker/skyblock/dungeon/DungeonMap.java Outdated Show resolved Hide resolved
@AzureAaron AzureAaron added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Mar 15, 2024
@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Mar 15, 2024
@AzureAaron AzureAaron linked an issue Mar 16, 2024 that may be closed by this pull request
Holding a Shortbow breaks Dungeons features #600
Closed
@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Mar 17, 2024
@kevinthegreat1 kevinthegreat1 merged commit 6448ef2 into SkyblockerMod:master Mar 18, 2024
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Holding a Shortbow breaks Dungeons features
3 participants
@Julienraptor01 @AzureAaron @kevinthegreat1