Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential stack overflow with chat rules #592

Merged

Conversation

kevinthegreat1
Copy link
Collaborator

Fix #590

@kevinthegreat1 kevinthegreat1 added bug Something isn't working reviews needed This PR needs reviews labels Mar 10, 2024
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did not test

@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Mar 12, 2024
@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews merge me please Pull requests that are ready to merge and removed merge me please Pull requests that are ready to merge reviews needed This PR needs reviews labels Mar 13, 2024
@kevinthegreat1
Copy link
Collaborator Author

oops wrong pr

@kevinthegreat1 kevinthegreat1 merged commit 969fa4f into SkyblockerMod:master Mar 18, 2024
1 check passed
@kevinthegreat1 kevinthegreat1 deleted the chat-rules-stack-overflow branch March 18, 2024 04:41
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.* and crash (StackOverflowError: null)
2 participants