Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breaks for force close world loading screen mod #587

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

AzureAaron
Copy link
Collaborator

The fourth issue was the last straw.

The fourth issue was the last straw.
@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Mar 7, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Mar 7, 2024
@kevinthegreat1 kevinthegreat1 added compatibility Adds compatibility for a new Minecraft version or a compatibility issue with other mods merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Mar 7, 2024
@viciscat
Copy link
Collaborator

viciscat commented Mar 7, 2024

Can't we make a conditionnal mixin with IMixinConfigPlugin? example

@AzureAaron
Copy link
Collaborator Author

Can't we make a conditionnal mixin with IMixinConfigPlugin? example

Done :)

@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Mar 12, 2024
@AzureAaron AzureAaron changed the title Add breaks for force close world loading screen mod Mixin compatibility for force close world loading screen mod & mixin bug Mar 12, 2024
@AzureAaron AzureAaron changed the title Mixin compatibility for force close world loading screen mod & mixin bug Mixin compatibility for force close world loading screen mod & Mixin bug Mar 12, 2024
@AzureAaron AzureAaron changed the title Mixin compatibility for force close world loading screen mod & Mixin bug Add breaks for force close world loading screen mod Mar 14, 2024
@kevinthegreat1 kevinthegreat1 removed the reviews needed This PR needs reviews label Mar 15, 2024
@kevinthegreat1 kevinthegreat1 merged commit 40fc055 into SkyblockerMod:master Mar 15, 2024
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Mar 17, 2024
@AzureAaron AzureAaron deleted the breaks-clause branch March 19, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Adds compatibility for a new Minecraft version or a compatibility issue with other mods
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants