Boulder Solver #540
Merged
Boulder Solver #540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LifeIsAParadox
added
new feature
kevinthegreat1
requested changes
Feb 11, 2024
| float lineWidth = 5.0f; | ||
|
|
||
| if (linePoints != null && linePoints.length > 0) { | ||
| RenderHelper.renderLinesFromPoints(context, linePoints, ORANGE_COLOR_COMPONENTS, alpha, lineWidth, true); |
There was a problem hiding this comment.
The lines need to be rendered one at a time for the line width and normals to not get messed up. (See the last part of Waterboard#render.)
Comment on lines
112
to
125
| /** | ||
| * Prints the current state of the game board to the console. | ||
| * Each character represents a type of BoulderObject or an empty space. | ||
| */ | ||
| public void printBoard() { | ||
| for (int x = 0; x < height; x++) { | ||
| for (int y = 0; y < width; y++) { | ||
| BoulderObject boulderObject = grid[x][y]; | ||
| String displayChar = (boulderObject != null) ? boulderObject.type() : "."; | ||
| System.out.print(displayChar); | ||
| } | ||
| System.out.println(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Doesn't really matter but maybe something like Waterboard#boardToString would be better since System.out.print is not hardcoded.
Comment on lines
87
to
93
| /** | ||
| * Represents a pair of objects, such as a game state and its associated path. | ||
| * | ||
| * @param <T> The type of the first object. | ||
| * @param <U> The type of the second object. | ||
| */ | ||
| private record Pair<T, U>(T first, U second) {} |
There was a problem hiding this comment.
it.unimi.dsi.fastutil.Pair should be a drop in replacement (except constructors calls has to be changed to Pair.of).
kevinthegreat1
added
changes requested
- it.unimi.dsi.fastutil.Pair instead of record Pair - printbard use of stringbuilder - render lines one at a time
LifeIsAParadox
added
reviews needed
kevinthegreat1
approved these changes
Feb 14, 2024
kevinthegreat1
added
merge me please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solver uses the A* search algorithm to get the shortest path.