Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable title and chat messages for Melon/Pumpkin Dicer #534

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Disable title and chat messages for Melon/Pumpkin Dicer #534

merged 4 commits into from
Feb 14, 2024

Conversation

Ghost-3
Copy link
Contributor

@Ghost-3 Ghost-3 commented Feb 4, 2024

Removes the annoying flashing title when using Dicer.
Also filters messages about drops in chat. (Disabled by default)

@AzureAaron AzureAaron added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Feb 6, 2024
kevinthegreat1
kevinthegreat1 requested changes Feb 8, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just some small things. Didn't test yet.

src/main/java/de/hysky/skyblocker/config/SkyblockerConfig.java Outdated Show resolved Hide resolved
src/main/resources/assets/skyblocker/lang/en_us.json Outdated Show resolved Hide resolved
@kevinthegreat1 kevinthegreat1 added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Feb 8, 2024
@Ghost-3
Copy link
Contributor Author

Ghost-3 commented Feb 8, 2024

All fixed.

kevinthegreat1
kevinthegreat1 reviewed Feb 11, 2024
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you confirm that it's still working after the latest changes? I'm not sure how to test it. Then I'll approve it.

@kevinthegreat1 kevinthegreat1 added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Feb 11, 2024
@Ghost-3
Copy link
Contributor Author

Ghost-3 commented Feb 11, 2024

Can you confirm that it's still working after the latest changes? I'm not sure how to test it. Then I'll approve it.

I confirm that everything is working.
To test it, you can buy a Pumpkin or Mellon Dicer and start harvesting pumpkins or melons in the garden.
By default, you will only see chat messages. You can disable chat messages and enable titles in the config.

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Feb 11, 2024
@kevinthegreat1 kevinthegreat1 merged commit c562f2d into SkyblockerMod:master Feb 14, 2024
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
new feature This issue or PR is a new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ghost-3 @kevinthegreat1 @AzureAaron