Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lowercase party and search strings to ignore case #513

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Jan 22, 2024

S+ wouldn't match s+ and vice-versa, so the results would be fewer for those looking for S+ lobbies and I guess it'd break numerous other searches due to capitalization not matching 100%.

@kevinthegreat1 kevinthegreat1 added the bug Something isn't working label Jan 23, 2024
@kevinthegreat1 kevinthegreat1 added the merge me please Pull requests that are ready to merge label Jan 23, 2024
@kevinthegreat1 kevinthegreat1 merged commit 2a447a5 into SkyblockerMod:master Jan 23, 2024
1 check passed
@Emirlol Emirlol deleted the fix-party-search branch January 23, 2024 12:20
@kevinthegreat1 kevinthegreat1 added this to the 1.17 milestone Jan 23, 2024
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants