Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add anita's talisman fortune boost indicator next to the relevant crop #512

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Jan 22, 2024

It was missing from the tab hud while being visible in the player list. I often had to Tab+M after Tab+N, that annoyed me so I added it.

I also saw a todo in the code about matching and displaying contest placement but I'm not sure what exactly to display where. I could add that too, but I'll need some more info.

Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but I couldn't test it. Do you have a screenshot?

@kevinthegreat1 kevinthegreat1 added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Jan 23, 2024
@Emirlol
Copy link
Collaborator Author

Emirlol commented Jan 23, 2024

Code looks good but I couldn't test it. Do you have a screenshot?

Sure:

image
image

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 23, 2024
@kevinthegreat1 kevinthegreat1 added this to the 1.17 milestone Jan 23, 2024
Copy link
Member

@LifeIsAParadox LifeIsAParadox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested works

@LifeIsAParadox LifeIsAParadox merged commit f3877c4 into SkyblockerMod:master Jan 25, 2024
1 check passed
@Emirlol Emirlol deleted the anita-fortune-tabhud branch January 25, 2024 17:24
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants