Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fishing timer appearing outside Skyblock. #508

Merged
merged 1 commit into from
Jan 20, 2024

Conversation

Kaluub
Copy link
Contributor

@Kaluub Kaluub commented Jan 20, 2024

Hello, this is a very simple fix, but the fishing helper does not work outside Skyblock. It will flash at the wrong time and it is otherwise inconsistent with the rest of the mod's behaviour outside Skyblock, which is why this commit removes it altogether.

@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Jan 20, 2024
@AzureAaron AzureAaron added this to the 1.17 milestone Jan 20, 2024
@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge bug Something isn't working and removed reviews needed This PR needs reviews labels Jan 20, 2024
@kevinthegreat1 kevinthegreat1 merged commit 08444dc into SkyblockerMod:master Jan 20, 2024
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants