Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed tips from true random to non-repeating random #501

Merged
merged 3 commits into from
Jan 20, 2024
Merged

Changed tips from true random to non-repeating random #501

merged 3 commits into from
Jan 20, 2024

Conversation

Emirlol
Copy link
Collaborator

@Emirlol Emirlol commented Jan 17, 2024

It's a bit confusing to get the same tip twice in a row, especially on your first use of the next tip. This PR fixes that and another minor annoyance.

@kevinthegreat1 kevinthegreat1 added the reviews needed This PR needs reviews label Jan 17, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm, didn't test.

@kevinthegreat1 kevinthegreat1 added tester needed This is used for a Discord webhook to create a thread and notify the tester. and removed reviews needed This PR needs reviews labels Jan 19, 2024
@kevinthegreat1 kevinthegreat1 added this to the 1.17 milestone Jan 19, 2024
@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed tester needed This is used for a Discord webhook to create a thread and notify the tester. labels Jan 20, 2024
@kevinthegreat1 kevinthegreat1 merged commit 35ab556 into SkyblockerMod:master Jan 20, 2024
1 check passed
@kevinthegreat1
Copy link
Collaborator

Thanks for contributing :)

@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 20, 2024
@Emirlol Emirlol deleted the prevent-same-tip branch January 22, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants