-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a custom GUI for the Party Finder in dungeons #487
Merged
kevinthegreat1
merged 19 commits into
SkyblockerMod:master
from
viciscat:dungeons_party_gui
Jan 20, 2024
Merged
Add a custom GUI for the Party Finder in dungeons #487
kevinthegreat1
merged 19 commits into
SkyblockerMod:master
from
viciscat:dungeons_party_gui
Jan 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
added
new feature
This issue or PR is a new feature
reviews needed
This PR needs reviews
labels
Jan 12, 2024
- Lazy fix for if there is no party host - Moved setting slot parse to the bottom row for loop
also fix the floor heads rendering in front of the overlay when party is locked
Remove useless generic type
also comment out that one line that creates an unused list
kevinthegreat1
previously approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, works great!
kevinthegreat1
added
merge me please
Pull requests that are ready to merge
and removed
reviews needed
This PR needs reviews
labels
Jan 20, 2024
kevinthegreat1
previously approved these changes
Jan 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still works great
kevinthegreat1
approved these changes
Jan 20, 2024
AzureAaron
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is it pretty? Debatable. Is it useful? Debatable. Did I enjoy making this?
Debatablekinda.Welp here's this thing. This should work but I haven't tested this much since I don't really play Skyblock much anymore. So maybe there's a one in thousand chance edge case scenario.
But there is a decent system where if it doesn't recognize an inventory it reverts back to the vanilla menu.
All widgets added to this aren't meant to be used else where since they are tailored to the whole communicating with the server thing.
Pretty much it I think.
Please do ask questions if you have any.