Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a custom GUI for the Party Finder in dungeons #487

Merged
merged 19 commits into from
Jan 20, 2024

Conversation

viciscat
Copy link
Collaborator

Is it pretty? Debatable. Is it useful? Debatable. Did I enjoy making this? Debatable kinda.
Welp here's this thing. This should work but I haven't tested this much since I don't really play Skyblock much anymore. So maybe there's a one in thousand chance edge case scenario.
But there is a decent system where if it doesn't recognize an inventory it reverts back to the vanilla menu.

All widgets added to this aren't meant to be used else where since they are tailored to the whole communicating with the server thing.

Pretty much it I think.

Please do ask questions if you have any.

@AzureAaron AzureAaron added this to the 1.17 milestone Jan 12, 2024
@AzureAaron AzureAaron added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Jan 12, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Jan 20, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works great!

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 20, 2024
kevinthegreat1
kevinthegreat1 previously approved these changes Jan 20, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works great

@kevinthegreat1 kevinthegreat1 merged commit 2cf648b into SkyblockerMod:master Jan 20, 2024
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants