Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Mixins #473

Merged
merged 3 commits into from
Jan 4, 2024
Merged

Audit Mixins #473

merged 3 commits into from
Jan 4, 2024

Conversation

AzureAaron
Copy link
Collaborator

Adds a test that audits all of the mod's Mixins, if an injection fails then an exception is thrown and the build will fail. The test report contains the necessary stack trace to debug the misbehaving Mixins (the stack trace is exactly the same as it would be if you tried to start the game and it crashed).

This should streamline development since you don't need to go through the process of running the game in order to test the mixins, you can either build the mod or just run the tests only to see if the Mixins are ok.

@AzureAaron AzureAaron added the reviews needed This PR needs reviews label Jan 2, 2024
@AzureAaron
Copy link
Collaborator Author

Moved this to the root package because it can't be in the mixins package even if its in the test source, I know that I pluralized the package name here and the actual one wasn't but I want to eventually make the mixins package name pluralized in the source so this should avoid conflicts in the future.

kevinthegreat1
kevinthegreat1 previously approved these changes Jan 3, 2024
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if we can fail the test if the audit fails.

src/test/java/de/hysky/skyblocker/MixinsTest.java Outdated Show resolved Hide resolved
@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 3, 2024
@AzureAaron AzureAaron merged commit 4d8bc4a into SkyblockerMod:master Jan 4, 2024
1 check passed
@AzureAaron AzureAaron deleted the audit-mixins branch January 4, 2024 06:55
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants