Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update fabric.mod.json access widener #455

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Update fabric.mod.json access widener #455

merged 1 commit into from
Dec 23, 2023

Conversation

kevinthegreat1
Copy link
Collaborator

Typo

@kevinthegreat1 kevinthegreat1 marked this pull request as ready for review December 19, 2023 09:03
@kevinthegreat1 kevinthegreat1 added bug Something isn't working reviews needed This PR needs reviews labels Dec 19, 2023
@AzureAaron
Copy link
Collaborator

I knew about this but ignored it because the accessor didn't need to be applied at runtime because it was used to access another inner class on the same parent class so only the compiler needed to be tricked.

@AzureAaron AzureAaron added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Dec 22, 2023
@AzureAaron AzureAaron merged commit e2a13ec into master Dec 23, 2023
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Dec 23, 2023
@AzureAaron AzureAaron deleted the access-widener branch December 23, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinthegreat1 @AzureAaron