Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JEI integration #448

Merged
merged 2 commits into from
Aug 18, 2024
Merged

Add JEI integration #448

merged 2 commits into from
Aug 18, 2024

Conversation

kevinthegreat1
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 commented Dec 8, 2023

Works. Custom recipe category and everything.

@kevinthegreat1 kevinthegreat1 added the wip This PR is a work in progress label Dec 8, 2023
@kevinthegreat1 kevinthegreat1 added this to the 1.17 milestone Jan 23, 2024
@kevinthegreat1 kevinthegreat1 modified the milestones: 1.17, 1.18 Jan 24, 2024
@InkEcau
Copy link

InkEcau commented Jan 29, 2024

Hi! Are you working on adding more categories? I'm considering coding for this. If I do, should I just submit a pull request to the master branch?

@kevinthegreat1
Copy link
Collaborator Author

Yes, I am working on adding jei integration. By more categories do you mean other recipes other than crafting? You are welcome to contribute.

@InkEcau
Copy link

InkEcau commented Jan 30, 2024

Yes! This is my current work in progress.(There are more descriptions about the recipe to be added.)
java_bkLmfw6mtU
java_jUeuICS4G7

@kevinthegreat1 kevinthegreat1 removed this from the 1.18 milestone Feb 19, 2024
@viciscat
Copy link
Collaborator

JEI 1.20.4 is out in beta btw

@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label May 9, 2024
@aiden-powers
Copy link
Contributor

would someone be so gang as to test this again if JEI is available

@aiden-powers
Copy link
Contributor

aiden-powers commented Aug 12, 2024

Actually now that I think about it, does this make JEI a hard dependency? This might delay Skyblocker updates until JEI is available for each new version if that's the case.

@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Aug 13, 2024
@kevinthegreat1
Copy link
Collaborator Author

Actually now that I think about it, does this make JEI a hard dependency? This might delay Skyblocker updates until JEI is available for each new version if that's the case.

No this does not.

@AzureAaron AzureAaron added this to the 1.22 milestone Aug 18, 2024
@AzureAaron AzureAaron added the new feature This issue or PR is a new feature label Aug 18, 2024
@AzureAaron AzureAaron added the changes requested This PR need changes label Aug 18, 2024
@LifeIsAParadox LifeIsAParadox removed the changes requested This PR need changes label Aug 18, 2024
@kevinthegreat1 kevinthegreat1 marked this pull request as ready for review August 18, 2024 09:05
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Aug 18, 2024
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Aug 18, 2024
@AzureAaron AzureAaron merged commit 31af537 into SkyblockerMod:master Aug 18, 2024
1 check passed
@LifeIsAParadox LifeIsAParadox removed the merge me please Pull requests that are ready to merge label Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants