Fix Secret Waypoints #413
Merged
Fix Secret Waypoints #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
added
bug
kevinthegreat1
force-pushed
the
dungeon-secrets-fix
branch
from
6dffba4
to
d23c1ac
Compare
AzureAaron
previously approved these changes
Nov 12, 2023
AzureAaron
added
merge me please
AzureAaron
approved these changes
Nov 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug with secret index parsing which caused
Room#roomMatchedto fail with an exception. The exceptions were unnoticed since it's executed using aCompleteableFuture.This caused rooms with fairy soul waypoints to fail to match silently.
Fixed a few bugged category entries in
secretlocationswhich caused secret category parsing to fail with an exception. This also causes room matching to fail silently since it's executed using aCompleteableFuture.This caused rooms containing the bugged category entries to fail to match silently.
To prevent this, logging is added for exceptional completion of the
CompleteableFuture, and tests are added to ensure category and waypoint serialization works properly.