Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player Secrets Tracker #394

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

AzureAaron
Copy link
Collaborator

Tracks the amount of secrets people get every run.

Also refactors Utils#isInDungeons to be based off locraw because M7 in p5 replaces the scoreboard data with the dragon's health so that would've returned false and caused the feature to not work.

@AzureAaron AzureAaron added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Oct 30, 2023
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some refactors, should probably be squashed so you get to keep the attribution.

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 30, 2023
@AzureAaron AzureAaron merged commit 5bb9110 into SkyblockerMod:master Oct 31, 2023
1 check passed
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Oct 31, 2023
@AzureAaron AzureAaron deleted the dungeon-secrets-tracker branch October 31, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants