Hypixel Api Proxy + Profile Id Caching #386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AzureAaron
force-pushed
the
hypixel-api
branch
from
10a04a5
to
0106d03
Compare
kevinthegreat1
previously approved these changes
Oct 26, 2023
AzureAaron
added
merge me please
AzureAaron
force-pushed
the
hypixel-api
branch
from
c0239d3
to
6cad1d2
Compare
kevinthegreat1
approved these changes
Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What we've all been waiting for.
Currently the proxy is hosted on my worker due to LIAP being busy and creating a custom cache involves lots of work and considerations. If the UA contains
Skyblockerthen it uses the mods key, all api responses from the mod are cached for 5 minutes on CF's network.There's support internally for detecting whether a response was served from the cache or not, it can be used to display warnings about cached/old data; CF also supplies the
Ageheader indicating the cached response's age so I can add that if there is interest.Profile id caching is also implemented because the museum endpoint only takes a profile id and sending an api request just to find a profile id is extremely wasteful.