Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some HUD options resetting sometimes #337

Merged
merged 4 commits into from
Oct 21, 2023
Merged

Fix some HUD options resetting sometimes #337

merged 4 commits into from
Oct 21, 2023

Conversation

AzureAaron
Copy link
Collaborator

When you go to a separate UI to configure a HUD position, then go back to the config it no longer forgets what you wanted it to be.

Fixes #336

@kevinthegreat1 kevinthegreat1 added changes requested This PR need changes wip This PR is a work in progress and removed changes requested This PR need changes labels Oct 7, 2023
@kevinthegreat1 kevinthegreat1 added this to the update mc to 1.20.2 milestone Oct 7, 2023
@AzureAaron
Fix some HUD options resetting sometimes
9d88534
@AzureAaron
Require YACL 3.2.1
da9f6fb 
3.2.0 will cause a game crash if you try to use it with the mod
@AzureAaron AzureAaron added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Oct 17, 2023
@AzureAaron
Copy link
Collaborator Author

Removed tip and marked as ready because I don't think there's a better path forward for this.

kevinthegreat1
kevinthegreat1 previously approved these changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe leave a TODO in TitleContainerConfigScreen#close?

@AzureAaron
Copy link
Collaborator Author

LGTM. Maybe leave a TODO in TitleContainerConfigScreen#close?

What would the todo be for?

@kevinthegreat1
Copy link
Collaborator

LGTM. Maybe leave a TODO in TitleContainerConfigScreen#close?

What would the todo be for?

It's a slightly janky solution and it might break in the future? Also, we're still waiting for yacl devs to offer some insights for this issue.

@AzureAaron
Copy link
Collaborator Author

LGTM. Maybe leave a TODO in TitleContainerConfigScreen#close?

What would the todo be for?

It's a slightly janky solution and it might break in the future? Also, we're still waiting for yacl devs to offer some insights for this issue.

oh ok, maybe an api idea for YACL is an optional identifier component on options/groups/categories which is defaulted to null that u can set on the option builder.

@kevinthegreat1 kevinthegreat1 added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Oct 18, 2023
@LifeIsAParadox LifeIsAParadox merged commit cb13f32 into SkyblockerMod:master Oct 21, 2023
1 check passed
@AzureAaron AzureAaron deleted the yacl3 branch October 23, 2023 03:53
@AzureAaron AzureAaron removed the merge me please Pull requests that are ready to merge label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.15
Development

Successfully merging this pull request may close these issues.

Dwarven HUD config does not save position
3 participants
@AzureAaron @kevinthegreat1 @LifeIsAParadox