-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Item cooldown display #332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some changes, and it should be good to go.
src/main/java/me/xmrvizzy/skyblocker/skyblock/item/ItemCooldowns.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/mixin/ClientPlayerInteractionManagerMixin.java
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/item/ItemCooldowns.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs translation strings for the config.
Also is it intended that if u break a non wood block the treecap cooldown shows?
I totally forgot about those.
No, this isn't indented and I added a check for that. |
src/main/java/me/xmrvizzy/skyblocker/skyblock/item/ItemCooldowns.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/config/categories/GeneralCategory.java
Outdated
Show resolved
Hide resolved
Why is this not just a mixin into |
Mixin directly into |
Ah I see. It might not be desired since the player may still want to break logs without the treecap effect and could potentially unintentionally fall foul of Hypixel rules about blocking clicks. |
src/main/java/me/xmrvizzy/skyblocker/skyblock/item/ItemCooldowns.java
Outdated
Show resolved
Hide resolved
8678c28
to
1618ac6
Compare
Adds an cooldown display to certain items.
Currently supported Items are:
There is a special case with the Treecapitator where its cooldown is reduced when a legendary monkey pet is equipped. I will add support for this case in a future PR, as it requires keeping track of which pet the player currently has equipped, which is beyond the scope of this PR.
The cooldown is displayed in two ways:
This PR remains a draft until #328 is merged.Preview
2023-10-03.14-28-54.mp4