Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locraw filter fix #314

Merged
merged 2 commits into from
Sep 17, 2023
Merged

Conversation

AzureAaron
Copy link
Collaborator

Previously due to an oversight the mod filtered out all locraw messages even the ones not triggered by the mod

Also made it so that the mod only updates the locraw info after the player switches worlds since it doesn't need to be every 15 seconds (although because of the oversight the mod only ever sent it after the player joined the world so nothing really changed here)

Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your second point was actually intentional. The mod only sends another locraw after 15 seconds if the first one fails.

@kevinthegreat1 kevinthegreat1 merged commit 8c88eb7 into SkyblockerMod:master Sep 17, 2023
1 check passed
@AzureAaron AzureAaron deleted the locraw-filter-fix branch September 17, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants