improve DungeonBlaze.java #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
LifeIsAParadox
commented
Aug 23, 2023
LifeIsAParadox
commented
- add javadoc
- using ArmorStandEntity instead of iterating every Entity
- reorganize large methods into clearer multiple smaller methods
- defined outlinecolor as constants
* add javadoc * using ArmorStandEntity instead iterating every Entity * reorganize large methods into clearer multiple smaller methods * defined outlinecolor as constants
| static boolean renderHooked = false; | ||
|
|
||
| private static final float[] WHITE_COLOR_COMPONENTS = {1.0f, 1.0f, 1.0f}; | ||
| private static final QuadColor outlineColorGreen = QuadColor.single(0.0F, 1.0F, 0.0F, 1f); |
There was a problem hiding this comment.
Suggested change
| private static final QuadColor outlineColorGreen = QuadColor.single(0.0F, 1.0F, 0.0F, 1f); | |
| private static final QuadColor outlineColorGreen = QuadColor.single(0.0f, 1.0f, 0.0f, 1.0f); |
for coherence with the other values
kevinthegreat1
requested changes
Aug 24, 2023
Comment on lines
152
to
153
| e.printStackTrace(); |
There was a problem hiding this comment.
Suggested change
| LOGGER.warn("[Skyblocker BlazeRenderer] " + e); | |
| e.printStackTrace(); | |
| LOGGER.warn("[Skyblocker Dungeon Blaze] Encountered an unknown exception", e); |
Something like this would be better than printStackTrace.
| */ | ||
| private static void handleException(Exception e) { | ||
| LOGGER.warn("[Skyblocker BlazeRenderer] Encountered an unknown exception" + e); |
There was a problem hiding this comment.
Suggested change
| LOGGER.warn("[Skyblocker BlazeRenderer] Encountered an unknown exception" + e); | |
| LOGGER.warn("[Skyblocker BlazeRenderer] Encountered an unknown exception", e); |
kevinthegreat1
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.