Fix broken Hypixel detection #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinthegreat1
approved these changes
Aug 7, 2023
|
Shouldn't have it been moved away from updateFromScoreboard since we don't get it from scoreboard anymore ? |
|
Yes, but it's probably more work than it's worth and I just merged it lol. |
Yeah fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hypixel seems to have some kind of a limit on the entires in the scoreboard, so sometimes the
www.hypixel.netgot cut out and thus broke the mods detection of whether its on hypixel (and by extension broke its ability to check if we're in skyblock or not).So now its based on the server ip!