-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Title container #196
Title container #196
Conversation
Implement TitleContainer for stacking titles. Implement Mania Indicator to show the player when they are standing on green terracotta during mania.
src/main/java/me/xmrvizzy/skyblocker/utils/title/TitleContainer.java
Outdated
Show resolved
Hide resolved
src/main/java/me/xmrvizzy/skyblocker/utils/title/TitleContainer.java
Outdated
Show resolved
Hide resolved
I’m a bit confused with the implementation. The titles seem to only turn off once the player leaves slayer? Also I feel like the new system is difficult to use. I imagine a more of a drop in replacement for the title would work better and be more maintainable. |
Title turn off when the titles active field is set to false. I’m not sure what you mean by it not being a drop in replacement how would you change it? |
I meant a system more similar to the current system, where I just have to call displayTitle with the parameters and a set time. I will take a closer look at this later. |
I can implement a method that can emulate that with the scheduler if you like. The reason it isn’t built in is so I can keep them for a unknown amount of time and update their text and color dynamically like I do with the mania indicator. |
Added a WIP configuration screen under /Skyblocker hud titleContainer that allows you to move, change alignment, and reorient the titles inside. Added methods(TitleContainer.addTitleWithDismiss, and RenderHelper.displayInTitleContainerWDismissAndPlaySound) that will display the given title and after a set amount of ticks will disable that title.
I refactored the code, but I noticed some things.
Sorry for being picky lol. |
Add +/- to change scale Mouse now properly goes to center for text box Added comments to rendering code
Adds two things