Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shortcuts #195

Merged
merged 12 commits into from
Jul 21, 2023
Merged

Shortcuts #195

merged 12 commits into from
Jul 21, 2023

Conversation

kevinthegreat1
Copy link
Collaborator

Add command shortcuts
See config screen and /skyblocker shortcuts

Fix StackOverflowError crash with FrustumInvoker

AzureAaron
AzureAaron requested changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@AzureAaron AzureAaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from the requested changes, this is quite a useful feature, works great so far and makes some commands less tedious such as p transferring.

src/main/java/me/xmrvizzy/skyblocker/skyblock/shortcut/Shortcuts.java Show resolved Hide resolved
src/main/java/me/xmrvizzy/skyblocker/skyblock/shortcut/ShortcutsConfigScreen.java Outdated Show resolved Hide resolved
@kevinthegreat1 kevinthegreat1 force-pushed the shortcuts branch 2 times, most recently from d30dc89 to a878d19 Compare July 4, 2023 06:23
@LifeIsAParadox
Copy link
Member

Resolve the conflicts, then I can approve the pr

@kevinthegreat1 kevinthegreat1 marked this pull request as draft July 10, 2023 01:14
@kevinthegreat1
Copy link
Collaborator Author

This pr is affected by this bug. We're waiting for it to be addressed.

@kevinthegreat1 kevinthegreat1 marked this pull request as ready for review July 19, 2023 03:23
AzureAaron
AzureAaron previously approved these changes Jul 20, 2023
View reviewed changes
@kevinthegreat1 kevinthegreat1 merged commit 14ec65e into SkyblockerMod:master Jul 21, 2023
1 check failed
@kevinthegreat1 kevinthegreat1 deleted the shortcuts branch July 21, 2023 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AzureAaron AzureAaron AzureAaron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kevinthegreat1 @LifeIsAParadox @AzureAaron