Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REI Compatibility #148

Merged
merged 8 commits into from
May 18, 2023
Merged

REI Compatibility #148

merged 8 commits into from
May 18, 2023

Conversation

lantice3720
Copy link
Contributor

Installed with Roughly Enough Items mod, makes it easier to search items.

kevinthegreat1
kevinthegreat1 requested changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with REI nor use it. So if you have tested this then it should be good.

build.gradle Show resolved Hide resolved
kevinthegreat1
kevinthegreat1 requested changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just want to confirm that you tested this. Other than that it looks good.

src/main/java/me/xmrvizzy/skyblocker/skyblock/itemlist/SkyblockCraftingRecipe.java Show resolved Hide resolved
@Julienraptor01
Copy link
Contributor

Is it automatically enabled if REI is installed and can it be manually disable with a setting ?

@lantice3720
Copy link
Contributor Author

lantice3720 commented May 17, 2023 •
edited
Loading

Is it automatically enabled if REI is installed and can it be manually disable with a settings ?

Yes. this is automatically enabled if REI is installed.
iirc REI can be disabled easily via settings but I'm not sure whether only one plugin(features added by Skyblocker) can.

kevinthegreat1
kevinthegreat1 previously approved these changes May 17, 2023
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

@kevinthegreat1 kevinthegreat1 merged commit f0f4137 into SkyblockerMod:master May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lantice3720 @Julienraptor01 @kevinthegreat1