Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minor updates #122

Merged
merged 18 commits into from
May 17, 2023
Merged

minor updates #122

merged 18 commits into from
May 17, 2023

Conversation

Fix3dll
Copy link
Contributor

@Fix3dll Fix3dll commented Mar 29, 2023

conflicts resolved compared to previous closed pr

@Fix3dll
a cleaner PriceInfoTooltip
13b09e3
@Fix3dll
fix recipe book
f362d95
@Fix3dll
fix freezing while open wiki and...
4a3b5a0 
get wiki link from local repo which is same and exist for recipe book
@Fix3dll
more readability for PriceInfoTooltip
47e9ec4
@Fix3dll
async updateItemRepo
ea05cbb
@Fix3dll
Merge branch '1.19.x'
2a1afe9 
# Conflicts:
#	src/main/java/me/xmrvizzy/skyblocker/config/SkyblockerConfig.java
#	src/main/java/me/xmrvizzy/skyblocker/skyblock/itemlist/ItemListWidget.java
@Fix3dll
conflicts resolved
16e61da
@Fix3dll
forgotten null check
da7f2e8
@Fix3dll
Merge branch 'master' into minor-updates
7f9e88b
@Fix3dll
Merge branch 'SkyblockerMod:master' into minor-updates
ab51894
@Fix3dll
fix average price on pets
d7a62f2 
and some cleanup for timestamp
@Fix3dll
add update repository command
21b64be 
"/skyblocker updaterepository"
@Fix3dll
forgot unversioned files :P
a32e5f5
@Fix3dll
Merge branch 'master' into minor-updates
704ace4
@Fix3dll
now runes have avg prices
06db7ab
@Fix3dll
fix wikiLink
6e58edd
@Fix3dll
Copy link
Contributor Author

Fix3dll commented Apr 22, 2023

If we have to say the changes made when I look back:

  • more readable and clean PriceInfoTooltip class
  • average BIN prices not displayed for pets now its fixed
  • when you try to open wiki with shortcut now it not freeze (async)
  • when you delete repo or first time using Skyblocker, repository downloading asynchronously. now there is no need to wait for the repository to download for the game to open. especially ideal for slow connections.
  • new async /skyblocker updaterepository command to update repository. new items, new recipes, new wiki links...
  • now we are getting runes avg price from api.
  • for wiki link "if wikiLink array index 1 null try to get 0" (this situation is open to improvement and added TODO comment)
    sorry if its missing

kevinthegreat1
kevinthegreat1 reviewed May 15, 2023
View reviewed changes
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Repository Update command usually is unnecessary right? Since JGit should update the repo on init every time.

@Fix3dll
Copy link
Contributor Author

Fix3dll commented May 16, 2023

The Repository Update command usually is unnecessary right? Since JGit should update the repo on init every time.

Actually the purpose of adding this command was to try async repository update. I didn't delete it after I was done, in case it could be evaluated for debug purposes in the future. I can remove it on request.

@kevinthegreat1
Copy link
Collaborator

Ah got it. LGTM.

@kevinthegreat1 kevinthegreat1 merged commit ae4a440 into SkyblockerMod:master May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinthegreat1 kevinthegreat1 kevinthegreat1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Fix3dll @kevinthegreat1