Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Fetchur solver not working by adding typo'ed variant #100

Merged
merged 2 commits into from
Nov 14, 2022

Conversation

Julienraptor01
Copy link
Contributor

I commented the non-typo variant so that we can notice when it'll be fixed cause solver won't work anymore and we'll just have to unpatch

I commented the non-typo variant so that we can notice when it'll be fixed cause solver won't work anymore and we'll just have to unpatch
@Julienraptor01 Julienraptor01 marked this pull request as ready for review November 14, 2022 21:32
@KonaeAkira
Copy link
Collaborator

I suggest you leave the correct spelling in place so the mod will continue to work when Hypixel fixes the typo.

@Julienraptor01
Copy link
Contributor Author

Julienraptor01 commented Nov 14, 2022

I suggest you leave the correct spelling in place so the mod will continue to work when Hypixel fixes the typo.

That mean that we won't know when they fix the typo easily and we'll have to check manually while here as soon as they fix it, it won't work, we can just uncomment a line and remove the useless one, but if you want me to leave the correct spelling, i'll do

@KonaeAkira
Copy link
Collaborator

I suggest you leave the correct spelling in place so the mod will continue to work when Hypixel fixes the typo.

That mean that we won't know when they fix the typo easily and we'll have to check manually while here as soon as they fix it, it won't work, we can just uncomment a line and remove the useless one, but if you want me to leave the correct spelling, i'll do

If the correct spelling is commented out and Hypixel fixes the typo, then users will have to update the mod for the solver to work again. Leaving the correct spelling in means that users don't have to update.

@KonaeAkira KonaeAkira merged commit d49ce40 into SkyblockerMod:master Nov 14, 2022
@Julienraptor01 Julienraptor01 deleted the patch-1 branch November 15, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants