-
Notifications
You must be signed in to change notification settings - Fork 35
Conversation
There are three faults in this test case:
|
- mysql-server | ||
|
||
mock-collector: | ||
image: skywalking/skywalking-mock-collector:{COLLECTOR_IMAGE_VERSION} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
image: skywalking/skywalking-mock-collector:{COLLECTOR_IMAGE_VERSION} | |
image: skyapm/mock-collector:{COLLECTOR_IMAGE_VERSION} |
spanLayer: Http | ||
tags: | ||
- key: url | ||
value: http://localhost:18080/shardingsphere-case/case/execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value: http://localhost:18080/shardingsphere-case/case/execute | |
value: http://localhost:{SERVER_OUTPUT_PORT}/shardingsphere-case/case/execute |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
entryEndpointId: 0 | ||
refType: CrossThread | ||
parentSpanId: 0 | ||
parentTraceSegmentId: not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that you should make sense the value of parentTraceSegmentId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The parent trace segmentId is unpredictable. During the last test is segmentId is .1.15562751912310010. Any suggestion?
entryEndpointId: 0 | ||
refType: CrossThread | ||
parentSpanId: 0 | ||
parentTraceSegmentId: not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that you should make sense the value of parentTraceSegmentId
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tuohai666 I can't see any information about data sharding or database orchestration from expected data. Is that miss this information in this scenario?
@ascrutae Thanks for your comments. The test case is a single routing scenario, and the expected data is same as actual data.
|
@tuohai666 Is single DB routing scenario enough? This case is designed to verify the plugin and benefit for shardingsphere ecosystem. We can't make that decision, but I think as a routing lib, it should test at least for two DBs. |
@wu-sheng Thanks for quick reply. I have tried full routing before this version of test case. The problem is that full routing can not guarantee the order of the executing threads, and leads to an unpredictable spans order. |
If SkyWalking's test framework can assert for concurrency(ignore execute's spans order), I prefer use two DBs scenario. |
entryEndpointId: 0 | ||
refType: CrossThread | ||
parentSpanId: 2 | ||
parentTraceSegmentId: not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parentTraceSegmentId: not null | |
parentTraceSegmentId: "${Your_ApplicationName[3]}" |
entryEndpointId: 0 | ||
refType: CrossThread | ||
parentSpanId: 2 | ||
parentTraceSegmentId: not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parentTraceSegmentId: not null | |
parentTraceSegmentId: "${Your_ApplicationName[3]}" |
entryEndpointId: 0 | ||
refType: CrossThread | ||
parentSpanId: 2 | ||
parentTraceSegmentId: not null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
parentTraceSegmentId: not null | |
parentTraceSegmentId: "${Your_ApplicationName[3]}" |
Please fill up those following information before send Pull request