Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Add go-micro plugins #4

Merged
merged 29 commits into from
Sep 28, 2020
Merged

Add go-micro plugins #4

merged 29 commits into from
Sep 28, 2020

Conversation

zaunist
Copy link
Contributor

@zaunist zaunist commented Aug 7, 2020

The test has not been completed yet, there may be some problems, I will correct them later

@kezhenxu94 kezhenxu94 added this to the 1.0.0 milestone Aug 7, 2020
@arugal arugal self-requested a review August 9, 2020 15:43
@zaunist
Copy link
Contributor Author

zaunist commented Sep 17, 2020

image

Copy link
Member

@arugal arugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Almost finished, you need to add an example and documentation.

micro/go.mod Outdated

// Package micro (sw_micro) is a plugin that can be used to trace Go-micro framework.

module swmicro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of the module should be github.com/SkyAPM/go2sky-plugins/go-micro, what do you think?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so

micro/swmicro.go Outdated

// Package micro (sw_micro) is a plugin that can be used to trace Go-micro framework.

package swmicro
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be go-micro.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will make changes on the next commit.

@arugal
Copy link
Member

arugal commented Sep 28, 2020

screenshots

image
image
image

Copy link
Member

@arugal arugal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, Thank you for contribution :)

@arugal arugal merged commit bdb1ce9 into SkyAPM:master Sep 28, 2020
@arugal
Copy link
Member

arugal commented Sep 28, 2020

@zaunist Would you be interested in adding the go-mirco in the component-library.yml :)

@zaunist
Copy link
Contributor Author

zaunist commented Sep 28, 2020

@zaunist Would you be interested in adding the go-mirco in the component-library.yml :)

I will add the go-micro in the component-library.yml later, thanks :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants