-
Notifications
You must be signed in to change notification settings - Fork 33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Almost finished, you need to add an example and documentation.
micro/go.mod
Outdated
|
||
// Package micro (sw_micro) is a plugin that can be used to trace Go-micro framework. | ||
|
||
module swmicro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the name of the module should be github.com/SkyAPM/go2sky-plugins/go-micro
, what do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think so
micro/swmicro.go
Outdated
|
||
// Package micro (sw_micro) is a plugin that can be used to trace Go-micro framework. | ||
|
||
package swmicro |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be go-micro
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will make changes on the next commit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LTGM, Thank you for contribution :)
@zaunist Would you be interested in adding the |
I will add the go-micro in the component-library.yml later, thanks :) |
The test has not been completed yet, there may be some problems, I will correct them later