Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Migration plugins #2

Merged
merged 7 commits into from
Jul 8, 2020
Merged

Migration plugins #2

merged 7 commits into from
Jul 8, 2020

Conversation

arugal
Copy link
Member

@arugal arugal commented Jul 3, 2020

@arugal arugal added this to the 0.4.1 milestone Jul 3, 2020
@arugal arugal changed the title Migration plugin Migration plugins Jul 3, 2020
@arugal arugal force-pushed the plugin branch 2 times, most recently from b12377b to 9496bf3 Compare July 5, 2020 05:55
@arugal arugal added test Test requirements about performance, feature or before release. plugin labels Jul 6, 2020
@arugal arugal marked this pull request as ready for review July 8, 2020 13:01
@wu-sheng wu-sheng merged commit d691d0a into master Jul 8, 2020
@wu-sheng wu-sheng deleted the plugin branch July 8, 2020 13:29
kezhenxu94
kezhenxu94 reviewed Jul 8, 2020
View reviewed changes
Makefile

LINTER := bin/golangci-lint
$(LINTER):
wget -q -O- https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | sh -s v1.20.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wget is not built-in in MacOS, curl is preferable so that we can run the check locally before pushing to the remote

tools/check-license-header.py
@@ -0,0 +1,74 @@
# Licensed to SkyAPM org under one or more contributor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file looks familiar 🧐

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/SkyAPM/go2sky/blob/master/tools/check-license-header.py Here is also :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this https://github.com/apache/skywalking-python/blob/master/tools/check-license-header.py 🤪

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kezhenxu94 kezhenxu94 kezhenxu94 left review comments

@wu-sheng wu-sheng wu-sheng approved these changes

@hanahmily hanahmily Awaiting requested review from hanahmily

Assignees
No one assigned
Labels
plugin test Test requirements about performance, feature or before release.
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@arugal @wu-sheng @kezhenxu94