Mac 18 call tasks api using mi #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofaulco
requested changes
Jul 20, 2022
|
|
||
| namespace SFA.DAS.EmployerAccounts.Interfaces | ||
| { | ||
| public interface ITasksClientApiConfiguration : IManagedIdentityClientConfiguration |
There was a problem hiding this comment.
I don't think this will work. This is creating a brand new interface which is in a different namespace to that which is injected into the registered client. When registering the DI, we should be using the Interface supplied by the nuget package.
There was a problem hiding this comment.
This was not being used and is removed now.
cofaulco
approved these changes
Jul 22, 2022
…mployerapprenticeshipsservice into MAC-18-Call-Tasks-API-Using-MI
…mployerapprenticeshipsservice into MAC-18-Call-Tasks-API-Using-MI
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.