update api for MI auth and update client package to use either client… #2294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… secret or MI to obtain bearer token.
ChrisJWoodcock
requested changes
May 23, 2022
There was a problem hiding this comment.
It looks like this isn't configured to be have audiences currently, so we should be doing this in a consistent style with other apps e.g. typically this is done using an AzureActiveDirectoryConfiguration section in the config file. Since there are not any clients (?) of the Finance API currently we could take the opportunity to drop the client configuration from employer config, not setting up the dependency in the client library and reduce the configuration to only the MI (ApiBaseUrl and IdentifierUrl) parts from the start and not bother checking for supplied client credentials.
ChrisJWoodcock
approved these changes
May 26, 2022
cofaulco
force-pushed
the
CON-4592_Finance-api-MI
branch
from
6c3f329 to
9b7e8d3
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… secret or MI to obtain bearer token.