CON-3951 - Revamped legal agreements page #2211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cofaulco
reviewed
Oct 4, 2021
| @item.Template.PublishedInfo | ||
| </a> | ||
| </li> | ||
| @Html.Partial("_AcceptedAgreement", agreement, new ViewDataDictionary{{"Inset", agreement.Template.InsetText(Model.Data) } }) |
There was a problem hiding this comment.
Is it worth using some sort of constant rather than hardcoding "Inset"
cofaulco
reviewed
Oct 4, 2021
| @@ -292,6 +292,8 @@ public async Task<ActionResult> WhenDoYouWantToView(int? choice, string agreemen | |||
| public async Task<ActionResult> ViewAllAgreements(string hashedAccountId, string accountLegalEntityHashedId) | |||
| { | |||
| var model = await _orchestrator.GetOrganisationAgreements(accountLegalEntityHashedId); | |||
| ViewBag.AgreementId = accountLegalEntityHashedId; | |||
There was a problem hiding this comment.
would it be better to have the "AgreementId" on the model rather than using viewbag?
cofaulco
approved these changes
Oct 4, 2021
added 4 commits
October 12, 2021 08:56
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.