[CON-1399] For some reason, payments seem to be being returned from t… #2030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he PaymentsEventsApi with a StandardCode of 0 rather than NULL when they in fact relate to a Framework. The code having previously always expected a NULL value for this property was checking HasValue(). Changed to check for a zero value if NULL and to assume that it is a framework otherwise. Also changed to log if both frameworkCode and standardCode not set
shomavg
approved these changes
Mar 3, 2020
Yes we have a separate ticket for a data fix CON-1544 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…he PaymentsEventsApi with a StandardCode of 0 rather than NULL when they in fact relate to a Framework. The code having previously always expected a NULL value for this property was checking HasValue(). Changed to check for a zero value if NULL and to assume that it is a framework otherwise. Also changed to log if both frameworkCode and standardCode not set