fix broken unit test

SkillsFundingAgency · Jan 22, 2021 · 33c5e20 · 33c5e20
1 parent 55644d4
commit 33c5e20
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/src/SFA.DAS.EmployerFinance/Services/PaymentService.cs b/src/SFA.DAS.EmployerFinance/Services/PaymentService.cs
@@ -78,13 +78,11 @@ public async Task<ICollection<PaymentDetails>> GetAccountPayments(string periodE
                     details.PeriodEnd = periodEnd;
                     var getCourseDetailsTask = GetCourseDetails(details);
 
-                    var provider = providerDetails[details.Ukprn];
+                    providerDetails.TryGetValue(details.Ukprn, out var provider);
                     details.ProviderName = provider?.Name;
                     details.IsHistoricProviderName = provider?.IsHistoricProviderName ?? false;
 
-                    var apprenticeship = apprenticeshipDetails[details.ApprenticeshipId];
-
-                    if (apprenticeship != null)
+                    if (apprenticeshipDetails.TryGetValue(details.ApprenticeshipId, out var apprenticeship))
                     {
                         details.ApprenticeName = $"{apprenticeship.FirstName} {apprenticeship.LastName}";
                         details.ApprenticeNINumber = apprenticeship.NINumber;
@@ -134,7 +132,9 @@ private async Task<Dictionary<long, Apprenticeship>> GetApprenticeshipDetailsDic
             //}
 
             var apprenticeships = await Task.WhenAll(taskList);
-            resultApprenticeships = apprenticeships.ToDictionary(app => app.Id, app => app);
+            resultApprenticeships = apprenticeships
+                .Where(app => app != null)
+                .ToDictionary(app => app.Id, app => app);
 
             return resultApprenticeships;
         }