-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Andrii/sketch/refactor to jsx3 #314
base: master
Are you sure you want to change the base?
Andrii/sketch/refactor to jsx3 #314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably should add comment to ReactOld.re explaining that it's deprecated and will be deleted once JSX2 to JSX3 migration is completed
.idea/.gitignore
Outdated
@@ -0,0 +1,8 @@ | |||
# Default ignored files |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrii-antiukhov Is it necessary to check these .idea files in?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, i do not know. It was changed not by me, maybe it should not be in GIT, but for this we should exclude this files .idea from GIT in .gitignore , maybe.
Migration to JSX3