Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Andrii/sketch/refactor to jsx3 #314

Draft
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

andrii-antiukhov
Copy link
Contributor

@andrii-antiukhov andrii-antiukhov commented Jan 7, 2022

Migration to JSX3

Copy link
Contributor

@feihong feihong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably should add comment to ReactOld.re explaining that it's deprecated and will be deleted once JSX2 to JSX3 migration is completed

.idea/.gitignore Outdated
@@ -0,0 +1,8 @@
# Default ignored files
Copy link
Contributor

@feihong feihong Jan 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrii-antiukhov Is it necessary to check these .idea files in?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, i do not know. It was changed not by me, maybe it should not be in GIT, but for this we should exclude this files .idea from GIT in .gitignore , maybe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants