Code

Code4rena Tests/Scripts Updates#122

Code

Merged

aviggiano merged 21 commits intocode4rena-deploySizeCredit/size-solidity:code4rena-deployfrom code4rena-audit-fixesSizeCredit/size-solidity:code4rena-audit-fixesCopy head branch name to clipboardJul 15, 2024

-5

Commits

Commits on Jul 15, 2024

• c4-001 Wrong decimal conversion in liquidation protocol split (#118)

  aviggiano

  authored
  a5ed979

  Copy full SHA for a5ed979

• c4-002 Wrong crLiquidation cap in overdue liquidation (#119)

  aviggiano

  authored
  58afa44

  Copy full SHA for 58afa44

• c4-003 Wrong fragmentationFee check in Compensate means it is never charged (#120)

  aviggiano

  authored
  a2a1c32

  Copy full SHA for a2a1c32

• c4-004 Chainlink heartbeats are different on Base and Ethereum mainnet (#123)

  Show description for e6be75f
  aviggiano

  authored
  e6be75f

  Copy full SHA for e6be75f

• c4-005 Users below crOpening cannot withdraw cash (#124)

  aviggiano

  authored
  6583a50

  Copy full SHA for 6583a50

• c4-006 DoS in market orders due to incorrect params.amount comparison… (#125)

  Show description for 8447c4d
  aviggiano

  authored
  8447c4d

  Copy full SHA for 8447c4d

• c4-007 Supply caps can be bypassed due to incorrect balanceOf (#126)

  aviggiano

  authored
  eb9e684

  Copy full SHA for eb9e684

• c4-008 Variable Pool liquidity check should validate balance of aToken, not Pool (#127)

  aviggiano

  authored
  5f9b633

  Copy full SHA for 5f9b633

• c4-010 Compensate is prevented if user is underwater (#129)

  Show description for 95310ad
  aviggiano

  authored
  95310ad

  Copy full SHA for 95310ad

• c4-011 Compensate ignores forSale after credit split (#130)

  aviggiano

  authored
  e0bc6e4

  Copy full SHA for e0bc6e4

• c4-012 getCreditPositionProRataAssignedCollateral can be simplified to totalCollateral * credit / totalDebt (#131)

  aviggiano

  authored
  d61fff1

  Copy full SHA for d61fff1

• c4-013 Liquidate does not have deadline protection (#132)

  Show description for 9873790
  aviggiano

  authored
  9873790

  Copy full SHA for 9873790

• c4-014 BuyCreditMarket returns incorrect value for liquidity check (#133)

  aviggiano

  authored
  ce014f9

  Copy full SHA for ce014f9

• c4-015 SelfLiquidation check can be simplified (#134)

  Show description for 49ef874
  aviggiano

  authored
  49ef874

  Copy full SHA for 49ef874

• c4-016 Documentation fixes (#135)

  Show description for 9eb0670
  aviggiano

  authored
  9eb0670

  Copy full SHA for 9eb0670

• c4-017 BorrowOffers do not have a maxDueDate (#136)

  Show description for bd3c2ea
  aviggiano

  authored
  bd3c2ea

  Copy full SHA for bd3c2ea

• c4-018 Wrong fee calculation in SellCreditMarket + exactAmountOut (#137)

  aviggiano

  authored
  1b06cb6

  Copy full SHA for 1b06cb6

• c4-019 Refactor fee calculation in AccountingLibrary.getCashAmountOut (#138)

  Show description for 0861e21
  aviggiano

  authored
  0861e21

  Copy full SHA for 0861e21

• Chainlink sequencer feed returns startedAt 0 if down (#140)

  aviggiano

  authored
  0c4ea37

  Copy full SHA for 0c4ea37

• c4-021 Add borrower to RepayStruct to avoid MEV (#141)

  Show description for e8c8a39
  aviggiano

  authored
  e8c8a39

  Copy full SHA for e8c8a39

• Merge branch 'code4rena-deploy' into code4rena-audit-fixes

  aviggiano

  authored
  7208fc2

  Copy full SHA for 7208fc2