Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiff: ccitt compression, fix for issue #2451 #2483

Merged
merged 3 commits into from
Jun 25, 2023
Merged

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable) (no test image available, which can be used publicly)

Description

This PR fixes #2541 as discussed here:
If we encounter a Extensions1D or 2D code, we read the next 5 bits and if it turns out to be a EOL and not a Extensions1D or 2D, we return that. Otherwise throw a NotSupported Exception for the Extension1D/2D code.

…r write premature EOL codes instead of extension codes.

Throw NotSupportedException, if its actually a Extension code. Fixes #2451
Copy link
Member

@JimBobSquarePants JimBobSquarePants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. 👍

@JimBobSquarePants JimBobSquarePants merged commit 2738b3a into main Jun 25, 2023
@JimBobSquarePants JimBobSquarePants deleted the bp/Issue2451 branch June 25, 2023 05:35
@JimBobSquarePants JimBobSquarePants added this to the v3.1.0 milestone Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants