-
-
Notifications
You must be signed in to change notification settings - Fork 851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use compile time constants over method for all MMShuffle operations. #2365
Conversation
@JimBobSquarePants It seems that this PR gives me some issues. I tried to execute the tests after this PR and over 1000 failed. I am seeing those Exception:
My environment:
When I run the tests in Release all tests pass. Running it in Debug fails the tests for me. |
You’re right! It’s a debug guard. Thanks! |
Have pushed a fix in #2369 |
Perhaps a good idea to run the tests in the CI pipeline in Debug mode? |
We’d maybe run a single entry in the matrix. I wouldn’t run more than that as it gets expensive. We want to preserve our release mode ones also to ensure we catch jit issues |
Prerequisites
Description
Fixes #2121
Ratios do seem to be better for Avx and Sse operations.
CC @gfoidl @tannergooding