Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiff Decoder option to decode only first frame #2013

Merged
merged 6 commits into from
Feb 28, 2022

Conversation

brianpopow
Copy link
Collaborator

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

As discussed in #1982, this adds the TiffDecoder option FrameDecodingMode, which allows to decode only the first frame.

@brianpopow brianpopow requested a review from a team February 18, 2022 15:44
@JimBobSquarePants
Copy link
Member

Looks good to me but I think we should hold for 2.1 release before merging this. I want the 2.0.1 release to contain critical bug fixes only.

@brianpopow
Copy link
Collaborator Author

Looks good to me but I think we should hold for 2.1 release before merging this. I want the 2.0.1 release to contain critical bug fixes only.

Yes sure, makes sense.

@JimBobSquarePants
Copy link
Member

@brianpopow I've decoded to skip 2.0.1 and do a 2.1 release instead. I think we've got a few good things to ship plus fixes.

@JimBobSquarePants JimBobSquarePants added this to the 2.*.* milestone Feb 28, 2022
@JimBobSquarePants JimBobSquarePants merged commit c40359f into main Feb 28, 2022
@JimBobSquarePants JimBobSquarePants deleted the bp/tiffonlyfirstframe branch February 28, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants