enable using github actions for build #1061

tocsoft · 2019-12-11T10:00:10Z

Prerequisites

I have written a descriptive pull-request title
I have verified that there are no overlapping pull-requests open
I have verified that I am following matches the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
I have provided test coverage for my change (where applicable)

Description

Adds a github workflow for building PRs using github actions and also build master branch on tags and merges.

On merges/tags packages are built and uploaded to github pacakge repository & for the time being myget (that can be phased out in the future are required.)

Known differences

Package number changes - due to the fact that github doesn't have build numbers we are generating the number from the date/time of the commit being built which should be unique and sequential enough for our use case.

As part of this PR i've also stopped Appveyor from publishing to the myget feed so we don't get a strange mix of packages up there.

Update

@JimBobSquarePants (me) added additional changes.

Build and test scripts are project agnostic and only rely on an environmental variable set in the yml for xunit (required for x86 tests).
Added targets netcorapp3.1, netstandard2.1 and set langversion to 8
Removed explicit net462 target from tests and added netcoreapp3.1
Replaced OpenCover with Coverlet
Replace custom versioning with compatible SemVer generated via GitVersion
Replaced obsolete ProjectIconUrl in nuspec properties
Stylecop is now referenced in all projects with reduced strictness in tests. (They're the Wild West of readability and we need a cleanup)
Cleanup of R# settings files (R# uses .editorconfig now ) and .vscode startup (It looked incorrect and if someone wants it they can PR)
Cleanup of other obsolete files.

+ publish to github package repository

codecov · 2019-12-11T11:27:54Z

Codecov Report

Merging #1061 into master will decrease coverage by 3.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1061      +/-   ##
==========================================
- Coverage   87.44%   83.71%   -3.73%     
==========================================
  Files        1131      688     -443     
  Lines       50041    28853   -21188     
  Branches     3677        0    -3677     
==========================================
- Hits        43756    24155   -19601     
+ Misses       5534     4698     -836     
+ Partials      751        0     -751

Flag	Coverage Δ
#unittests	`83.71% <ø> (?)`

Impacted Files	Coverage Δ
...ocessing/Extensions/Drawing/DrawImageExtensions.cs	`95.65% <ø> (ø)`	⬆️
...rocessing/Processors/Drawing/DrawImageProcessor.cs	`100% <ø> (ø)`	⬆️
...lorSpaces/Conversion/ColorSpaceConverterOptions.cs	`57.14% <0%> (-42.86%)`	⬇️
src/ImageSharp/Processing/ResizeOptions.cs	`71.42% <0%> (-28.58%)`	⬇️
...s/Convolution/Convolution2PassProcessor{TPixel}.cs	`84% <0%> (-16%)`	⬇️
src/ImageSharp/Formats/Png/PngEncoder.cs	`84.61% <0%> (-15.39%)`	⬇️
...sors/Convolution/Convolution2DProcessor{TPixel}.cs	`84.61% <0%> (-15.39%)`	⬇️
...essors/Convolution/ConvolutionProcessor{TPixel}.cs	`84.72% <0%> (-15.28%)`	⬇️
src/ImageSharp/Primitives/ColorMatrix.cs	`77.36% <0%> (-11.58%)`	⬇️
src/ImageSharp/Formats/Bmp/BmpInfoHeader.cs	`84.61% <0%> (-7%)`	⬇️
... and 624 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1df496...2e8f50d. Read the comment docs.

JimBobSquarePants · 2019-12-11T13:00:55Z

I'm super excited about this! We can finally target NET Core 3+

I'll have a proper dig through the config as soon as I can. Only question I have straight away is that I can only see a subset of the original target frameworks from AppVeyor. Is that intentional?

tocsoft · 2019-12-12T07:58:21Z

It was somewhat intentional, removing the net642 targets was intentional they are so old i feel we can just drop version/target now. Totally forgot about x86 netcore and also mono.

JimBobSquarePants · 2019-12-12T10:35:09Z

It was somewhat intentional, removing the net642 targets was intentional they are so old i feel we can just drop version/target now. Totally forgot about x86 netcore and also mono.

I guess I'm ok with that considering the warning regarding NET 4.6x from the docs

While NuGet considers .NET Framework 4.6.1 as supporting .NET Standard 1.5 through 2.0, there are several issues with consuming .NET Standard libraries that were built for those versions from .NET Framework 4.6.1 projects. For .NET Framework projects that need to use such libraries, we recommend that you upgrade the project to target .NET Framework 4.7.2 or higher.

I'm curious to see how fast the builds/tests are on here though with the full suite as they seem to be rocket powered looking at the individual numbers.

build.ps1

Directory.Build.props

tests/ImageSharp.Tests/ImageSharp.Tests.csproj

antonfirsov · 2019-12-12T13:31:04Z

I really want to do a deeper review on this during the weekend.

For now, only one comment:
If we drop test execution on .NET 4.6.2, we should explicitly state that that platform is no longer supported, and bugs reported against that platform will not be fixed.

.github/workflows/build-and-test.yml

build.ps1

…ctions

…eSharp into sw/github-actions

.github/workflows/build-and-test.yml.bak

.gitignore

.github/workflows/build-and-test.yml

tests/Directory.Build.targets

tests/ImageSharp.Benchmarks/ImageSharp.Benchmarks.csproj

brianpopow

looks good to me, good job @tocsoft and @JimBobSquarePants

antonfirsov · 2020-01-17T10:20:37Z

There are massive changes that may effect local dev experience. Gonna check the branch tonight with Rider.

antonfirsov

Great job with the CI! 🎉

But I have to disagree with the sudden introduction of StyleCop in tests. Having 7632 😱 warnings completely hangs my Rider, making it impossible to edit stuff.

We should introduce rules incrementally in separate PR-s, including fixes for the rules being introduced.

JimBobSquarePants · 2020-01-17T21:44:50Z

You and your toy IDE 😝

It’s a blanket off and on case with stylecop. You have to specify the rules and turn them off individually.

I’ll disable for now in tests and re-add them with another PR fixing them. It would only take me a couple of hours.

brianpopow · 2020-01-17T23:24:58Z

You and your toy IDE 😝

It’s a blanket off and on case with stylecop. You have to specify the rules and turn them off individually.

I’ll disable for now in tests and re-add them with another PR fixing them. It would only take me a couple of hours.

Im not sure if, we should enable stylecop rules in tests at all. Myself i would not care about it, but i had some colleagues in the past who really disliked those rules. I think writing tests is a chore by itself and we should not make it harder by enforcing style rules on them. I think its ok, if its a bit of a wild west in the tests.

JimBobSquarePants · 2020-01-17T23:30:02Z

Im not sure if, we should enable stylecop rules in tests at all. Myself i would not care about it, but i had some colleagues in the past who really disliked those rules. I think writing tests is a chore by itself and we should not make it harder by enforcing style rules on them. I think its ok, if its a bit of a wild west in the tests.

The rules are much less strict than the main src and we can tweak them as need be. We need something though. The tests are difficult to follow at points which is dangerous.

brianpopow · 2020-01-17T23:39:56Z

I’ll disable for now in tests and re-add them with another PR fixing them. It would only take me a couple of hours.

ok then, if you want i can do that. I have some free time next week, i would not mind to do that.

antonfirsov · 2020-01-17T23:58:26Z

I think even relaxed ruleset is worth a review to make sure they don't harm readability by eg. enforcing rules on Member Data formatting which are impractical here. (There might be no such case in practice - just an example to emphasize that we should be careful.)

Fortuanately StyleCop's automatic formatters seem to work much better today (at least with Rider). A few years ago, when I had to fix everything manually, it was a terrible & frustrating productivity killer for me. I used to fight until my last blood to keep SC far from the test code 😄

ci-test.ps1

antonfirsov · 2020-01-18T00:22:15Z

.github/workflows/build-and-test.yml

+                      codecov: false
+                    - os: windows-latest
+                      framework: netcoreapp3.1
+                      runtime: -x64


It's worth to also test x86 + 3.1 because of the floating point magic we do.

tocsoft added 2 commits December 11, 2019 09:51

enable using github actions for building

3d1d7f8

+ publish to github package repository

stop appveyor publishing pacakges

6e2ba68

Merge branch 'master' into sw/github-actions

6a234af

JimBobSquarePants reviewed Dec 12, 2019

View reviewed changes

build.ps1 Outdated Show resolved Hide resolved

Directory.Build.props Show resolved Hide resolved

tests/ImageSharp.Tests/ImageSharp.Tests.csproj Outdated Show resolved Hide resolved

JimBobSquarePants mentioned this pull request Dec 14, 2019

Add La16 and La32 IPixel formats. #1062

Merged

4 tasks

JimBobSquarePants reviewed Dec 15, 2019

View reviewed changes

.github/workflows/build-and-test.yml Outdated Show resolved Hide resolved

JimBobSquarePants reviewed Dec 18, 2019

View reviewed changes

build.ps1 Outdated Show resolved Hide resolved

JimBobSquarePants and others added 18 commits January 9, 2020 21:44

Merge branch 'master' into sw/github-actions

af7077a

Merge remote-tracking branch 'remotes/origin/master' into sw/github-a…

991d6cb

…ctions

Merge branch 'sw/github-actions' of https://github.com/SixLabors/Imag…

a1df496

…eSharp into sw/github-actions

Merge branch 'master' into sw/github-actions

cb0597a

Use dotnet test

b12dd69

Update build-and-test.yml

9fdc4ea

Remove old xunit reference

a1d2e6f

Debug framework skipping

fc6ac75

Skip linux for testing

df66a98

Update build-and-test.yml

60ab03b

Use pwsh for scripts

92e5d5c

Fix options naming

44733d3

Fix booleans?

69f3d18

Conditionals are hard.

3337d2d

Update build-and-test.yml

3755f88

Fix missing quote

c7fdf1a

Update build-and-test.yml

e2f090a

Fix tests

abde989

JimBobSquarePants added 4 commits January 16, 2020 22:31

Try using bash

c41a4c4

Test all frameworks

a639460

Only use the xunit runner when we really have to.

a8425dd

Restore CI variable and skip troublesome tests

5f06fb9

JimBobSquarePants requested a review from a team January 16, 2020 13:21

JimBobSquarePants reviewed Jan 16, 2020

View reviewed changes

.github/workflows/build-and-test.yml.bak Outdated Show resolved Hide resolved

JimBobSquarePants reviewed Jan 16, 2020

View reviewed changes

.gitignore Outdated Show resolved Hide resolved

Delete bak file and undo bad gitignore changes

45bc1bc

brianpopow reviewed Jan 16, 2020

View reviewed changes

.github/workflows/build-and-test.yml Show resolved Hide resolved

tests/Directory.Build.targets Outdated Show resolved Hide resolved

tests/ImageSharp.Benchmarks/ImageSharp.Benchmarks.csproj Show resolved Hide resolved

JimBobSquarePants added 3 commits January 17, 2020 11:37

Speed up coverage and respond to comments

21ad572

Update ci-test.ps1

1d4887f

Fix netstandard 1.3 build

3a64f92

brianpopow approved these changes Jan 17, 2020

View reviewed changes

antonfirsov requested changes Jan 17, 2020

View reviewed changes

Temporarily disable Stylecop in tests

2e8f50d

antonfirsov reviewed Jan 18, 2020

View reviewed changes

ci-test.ps1 Show resolved Hide resolved

antonfirsov approved these changes Jan 18, 2020

View reviewed changes

antonfirsov reviewed Jan 18, 2020

View reviewed changes

JimBobSquarePants merged commit 00e9093 into master Jan 18, 2020

JimBobSquarePants deleted the sw/github-actions branch January 18, 2020 00:27

JimBobSquarePants added the area:build label Apr 24, 2020

JimBobSquarePants added this to the 1.0.0-rc1 milestone Apr 24, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enable using github actions for build #1061

enable using github actions for build #1061

tocsoft commented Dec 11, 2019 •

edited by JimBobSquarePants

Loading

codecov bot commented Dec 11, 2019 •

edited

Loading

JimBobSquarePants commented Dec 11, 2019

tocsoft commented Dec 12, 2019

JimBobSquarePants commented Dec 12, 2019 •

edited

Loading

antonfirsov commented Dec 12, 2019

brianpopow left a comment

antonfirsov commented Jan 17, 2020 •

edited

Loading

antonfirsov left a comment

JimBobSquarePants commented Jan 17, 2020

brianpopow commented Jan 17, 2020

JimBobSquarePants commented Jan 17, 2020

brianpopow commented Jan 17, 2020

antonfirsov commented Jan 17, 2020

antonfirsov Jan 18, 2020 •

edited

Loading

enable using github actions for build #1061

enable using github actions for build #1061

Conversation

tocsoft commented Dec 11, 2019 • edited by JimBobSquarePants Loading

Prerequisites

Description

Known differences

Update

codecov bot commented Dec 11, 2019 • edited Loading

Codecov Report

JimBobSquarePants commented Dec 11, 2019

tocsoft commented Dec 12, 2019

JimBobSquarePants commented Dec 12, 2019 • edited Loading

antonfirsov commented Dec 12, 2019

brianpopow left a comment

Choose a reason for hiding this comment

antonfirsov commented Jan 17, 2020 • edited Loading

antonfirsov left a comment

Choose a reason for hiding this comment

JimBobSquarePants commented Jan 17, 2020

brianpopow commented Jan 17, 2020

JimBobSquarePants commented Jan 17, 2020

brianpopow commented Jan 17, 2020

antonfirsov commented Jan 17, 2020

antonfirsov Jan 18, 2020 • edited Loading

Choose a reason for hiding this comment

tocsoft commented Dec 11, 2019 •

edited by JimBobSquarePants

Loading

codecov bot commented Dec 11, 2019 •

edited

Loading

JimBobSquarePants commented Dec 12, 2019 •

edited

Loading

antonfirsov commented Jan 17, 2020 •

edited

Loading

antonfirsov Jan 18, 2020 •

edited

Loading