Feature/metrics chart #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shankha-das
suggested changes
Aug 22, 2022
Comment on lines
+181
to
+182
| }, | ||
| ]; |
There was a problem hiding this comment.
Please add a empty line below. You can also use Prettify to format this file.
| id="discover.noResults.queryMayNotMatchTitle" | ||
| values={Object {}} | ||
| > | ||
| Your query may not match anything in the current time range, or there may not be any data at all in the currently selected time range. Try change time range, query filters or choose different time fields | ||
| Your query may not match anything in the current time range, or there may not be any data at all in | ||
| the currently selected time range. Try change time range, query filters or choose different time fields | ||
| </FormattedMessage> | ||
| </p> | ||
| </div> |
There was a problem hiding this comment.
We don't push this snapshot. Please revert this file to its past state.
| @@ -43,6 +43,7 @@ | |||
|
|
|||
| ::-webkit-scrollbar { | |||
| width: 10px; | |||
| height: 10px; | |||
Comment on lines
67
to
68
| initialIsOpen | ||
| id="configPanel__legend" |
Comment on lines
+98
to
+101
| } else if (visualizations.vis.name === visChartTypes.Metrics) { | ||
| setConfigList({ | ||
| metrics: [initialConfigEntry], | ||
| }); |
There was a problem hiding this comment.
please take a pull of latest code, we are using switch case here in place of if-else
| </EuiFlexItem> | ||
| </> | ||
| ); | ||
| }; |
There was a problem hiding this comment.
We have changed this file. Please update the config list according to valueOptions
| id: 'fontsize', | ||
| name: 'Metric FontSize', | ||
| editor: ConfigLegend, | ||
| mapTo: 'FontSize', |
Comment on lines
+17
to
+19
| const dataConfigTab = | ||
| visualizations.data?.rawVizData?.metrics?.dataConfig && | ||
| visualizations.data.rawVizData.metrics.dataConfig; |
There was a problem hiding this comment.
Take a pull of the latest code with valueOptions and check whether this still works or not.
Comment on lines
28
to
37
| if (aggregate === 'COUNT') { | ||
| return data[label].length; | ||
| } else if (aggregate === 'AVERAGE') { | ||
| return meanBy(data[label]).toFixed(2); | ||
| } else if (aggregate === 'MAX') { | ||
| return (max(data[label]) as number).toFixed(2); | ||
| } else if (aggregate === 'MIN') { | ||
| return (min(data[label]) as number).toFixed(2); | ||
| } else if (aggregate === 'SUM') { | ||
| return sum(data[label]).toFixed(2); |
Signed-off-by: SivaprasadAluri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added Metrics Chart Styles Panel
Issues Resolved
opensearch-project#872