Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make descendents of fully clipped nodes invisible #848

Merged
merged 8 commits into from
Jul 1, 2021
Merged

Make descendents of fully clipped nodes invisible #848

merged 8 commits into from
Jul 1, 2021

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Jul 1, 2021

Resolves #731

Plus a bit a refactor/streamlining of isVisible and isClipped.

@Jym77 Jym77 added the patch Backwards-compatible change that doesn't touch public API label Jul 1, 2021
@Jym77 Jym77 self-assigned this Jul 1, 2021
kasperisager
kasperisager previously requested changes Jul 1, 2021
View reviewed changes
packages/alfa-rules/src/common/predicate/is-clipped.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/common/predicate/is-clipped.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/common/predicate/is-visible.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/common/predicate/has-computed-style.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/common/predicate/is-clipped.ts Outdated Show resolved Hide resolved
packages/alfa-rules/src/common/predicate/is-visible.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 dismissed kasperisager’s stale review July 1, 2021 11:45

Changes done

@Jym77 Jym77 requested a review from kasperisager July 1, 2021 11:45
kasperisager
kasperisager approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 👏

@Jym77 Jym77 merged commit ae12dc0 into main Jul 1, 2021
@Jym77 Jym77 deleted the make-fully-indented-node-invisible branch July 1, 2021 12:31
kasperisager added a commit that referenced this pull request Jul 2, 2021
@kasperisager
Merge branch 'main' into api-extractor
663ddb4 
* main:
  Move some documentation files around
  Make descendents of fully clipped nodes invisible (#848)
  Use built-in caching of `actions/setup-node`
  Bump actions/setup-node from 2.1.5 to 2.2.0 (#849)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperisager kasperisager kasperisager approved these changes

@elenamongelli elenamongelli Awaiting requested review from elenamongelli

Assignees

@Jym77 Jym77

Labels
patch Backwards-compatible change that doesn't touch public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isClippedBySize() does not account for cases where the grandparent of a text node fully indents and clips text
2 participants
@Jym77 @kasperisager