Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support font shorthand property #693

Merged
merged 30 commits into from
Feb 9, 2021
Merged

Support font shorthand property #693

merged 30 commits into from
Feb 9, 2021

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Feb 8, 2021 •
edited by kasperisager
Loading

Resolves #682

Jym77 added 20 commits February 5, 2021 13:26
@Jym77
Add type to turn strings into keywords
757c67d
@Jym77
Support font-stretch longhand
03039cf
@Jym77
Implement font shorthand
59098fa
@Jym77
Actually define the font shorthand
9663be6
@Jym77
Pass input to Parser.tee callback
ee83945
@Jym77
Allow error callback in Parser.tee
2b937b7
@Jym77
Rename Parser.mapResult to Parser.andThen to align with Result.andThen
f48cb1e
@Jym77
Use Result.andThen in Parser.andThen
38227f7
@Jym77
Remove unused import
404ed0f
@Jym77
Fix whitespacing in parser
d5718c1
@Jym77
Restrict font-stretch to <font-stretch-css3> in font shorthand
968cad3
@Jym77
Make whitespace around font-size/line-height separator optional
a500c35
@Jym77
Correct percentages?
d65190f
@Jym77
Correct Percentage.toString
fc7c167
@Jym77
Allow angles in font-style
0fa82d2
@Jym77
Allow whitespace in font-size: oblique 25deg
eae986c
@Jym77
Add test for font shorthand
e15d859
@Jym77
Clean up
c362f94
@Jym77
Revert Parser.andThen to Parser.mapResult
8e4b723
@Jym77
Clean up
3aeafc0
@Jym77 Jym77 added the major Backwards-incompatible change that touches public API label Feb 8, 2021
@Jym77 Jym77 requested a review from kasperisager February 8, 2021 14:36
@Jym77 Jym77 self-assigned this Feb 8, 2021
@Jym77 Jym77 removed the request for review from kasperisager February 8, 2021 14:50
@Jym77 Jym77 requested a review from kasperisager as a code owner February 8, 2021 14:51
@Jym77 Jym77 marked this pull request as draft February 8, 2021 14:51
@Jym77
Copy link
Contributor Author

Jym77 commented Feb 8, 2021

Arf, need more heavy handed work to handle font-style… (or maybe just ignore the extra angle due to poor browser support).

@Jym77 Jym77 marked this pull request as ready for review February 8, 2021 14:55
@kasperisager kasperisager added minor Backwards-compatible change that touches public API and removed major Backwards-incompatible change that touches public API labels Feb 8, 2021
kasperisager
kasperisager previously requested changes Feb 9, 2021
View reviewed changes
packages/alfa-style/src/property/font.ts Outdated Show resolved Hide resolved
packages/alfa-style/src/property/font.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 requested a review from kasperisager February 9, 2021 09:27
kasperisager
kasperisager previously requested changes Feb 9, 2021
View reviewed changes
packages/alfa-css/src/value/keyword.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 requested a review from kasperisager February 9, 2021 09:52
kasperisager
kasperisager previously requested changes Feb 9, 2021
View reviewed changes
packages/alfa-css/src/value/keyword.ts Outdated Show resolved Hide resolved
@Jym77 Jym77 requested a review from kasperisager February 9, 2021 10:19
kasperisager
kasperisager approved these changes Feb 9, 2021
View reviewed changes
Copy link
Contributor

@kasperisager kasperisager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🎉

@Jym77 Jym77 merged commit 66d40b0 into master Feb 9, 2021
@Jym77 Jym77 deleted the support-font-shorthand branch February 9, 2021 10:54
kasperisager added a commit that referenced this pull request Feb 10, 2021
@kasperisager
Merge branch 'master' into api-extractor
b8e4101 
* master: (477 commits)
  Add @siteimprove/alfa-selective package (#702)
  Implement `Hashable` for `Either<L, R>`
  Bump typescript from 4.1.3 to 4.1.4 (#701)
  Add @siteimprove/alfa-network package (#696)
  Rework @siteimprove/alfa-trilean package (#695)
  Add @siteimprove/alfa-sarif package (#694)
  Support `font` shorthand property (#693)
  Update changelog
  Add additional `Array` functions
  Bump highlight.js from 10.5.0 to 10.6.0 (#697)
  Add additional `Sequence` test case
  Remove unneeded test
  Clean up R69 tests
  Refactor JSON internals
  Adjust `Emitter<T>` and add tests
  Add additional JSON props to ARIA types
  Add some missing package references
  Formatting
  Housekeeping
  Swap some uses of `Ok.of()` for `Result.of()`
  ...
kasperisager added a commit that referenced this pull request Feb 10, 2021
@kasperisager
Merge branch 'master' into native-source-maps
f891051 
* master: (572 commits)
  Add @siteimprove/alfa-selective package (#702)
  Implement `Hashable` for `Either<L, R>`
  Bump typescript from 4.1.3 to 4.1.4 (#701)
  Add @siteimprove/alfa-network package (#696)
  Rework @siteimprove/alfa-trilean package (#695)
  Add @siteimprove/alfa-sarif package (#694)
  Support `font` shorthand property (#693)
  Update changelog
  Add additional `Array` functions
  Bump highlight.js from 10.5.0 to 10.6.0 (#697)
  Add additional `Sequence` test case
  Remove unneeded test
  Clean up R69 tests
  Refactor JSON internals
  Adjust `Emitter<T>` and add tests
  Add additional JSON props to ARIA types
  Add some missing package references
  Formatting
  Housekeeping
  Swap some uses of `Ok.of()` for `Result.of()`
  ...
kasperisager added a commit that referenced this pull request Feb 10, 2021
@kasperisager
Merge branch 'master' into yarn-berry
f48b0fa 
* master: (322 commits)
  Add @siteimprove/alfa-selective package (#702)
  Implement `Hashable` for `Either<L, R>`
  Bump typescript from 4.1.3 to 4.1.4 (#701)
  Add @siteimprove/alfa-network package (#696)
  Rework @siteimprove/alfa-trilean package (#695)
  Add @siteimprove/alfa-sarif package (#694)
  Support `font` shorthand property (#693)
  Update changelog
  Add additional `Array` functions
  Bump highlight.js from 10.5.0 to 10.6.0 (#697)
  Add additional `Sequence` test case
  Remove unneeded test
  Clean up R69 tests
  Refactor JSON internals
  Adjust `Emitter<T>` and add tests
  Add additional JSON props to ARIA types
  Add some missing package references
  Formatting
  Housekeeping
  Swap some uses of `Ok.of()` for `Result.of()`
  ...
kasperisager added a commit that referenced this pull request Feb 11, 2021
@kasperisager
Merge branch 'master' into eslint
5bdc642 
* master: (493 commits)
  Upgrade to Yarn Berry (#258)
  Bump webdriverio from 6.12.1 to 7.0.1 (#700)
  Add user agent styles for form controls
  Switch to native Node.js source map support (#267)
  Bump @angular/core from 11.1.2 to 11.2.0 (#705)
  Bump typescript from 4.1.4 to 4.1.5 (#704)
  Bump @types/chai from 4.2.14 to 4.2.15 (#703)
  Add missing package references
  Add missing package references
  Add @siteimprove/alfa-selective package (#702)
  Implement `Hashable` for `Either<L, R>`
  Bump typescript from 4.1.3 to 4.1.4 (#701)
  Add @siteimprove/alfa-network package (#696)
  Rework @siteimprove/alfa-trilean package (#695)
  Add @siteimprove/alfa-sarif package (#694)
  Support `font` shorthand property (#693)
  Update changelog
  Add additional `Array` functions
  Bump highlight.js from 10.5.0 to 10.6.0 (#697)
  Add additional `Sequence` test case
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kasperisager kasperisager kasperisager approved these changes

Assignees

@Jym77 Jym77

Labels
minor Backwards-compatible change that touches public API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement font CSS property
2 participants
@Jym77 @kasperisager