Introduce @siteimprove/alfa-url package
#421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
added
the
major
Jym77
approved these changes
Oct 2, 2020
kasperisager
added a commit
that referenced
this pull request
Oct 5, 2020
* master: Update changelog Introduce `@siteimprove/alfa-url` package (#421) Mark `Property` as internal Default `Import` condition to `None`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new
@siteimprove/alfa-urlpackage with an implementation of an immutable URL class modelled on the WHATWG URL specification. An obvious question might be "why not just use the WHATWG URL DOM API?" to which the obvious answer is "well, it kinda does". That is,URL.parse()relies on the WHATWG URL DOM API for parsing URL strings and extracting URL records. From there, theURLclass also adds some convenience like implementations ofEquatable,Hashable, andSerializable, making it easy to useURLinstances in the various data structures Alfa provides.The caveat to this approach is of course that we now rely on the WHATWG URL specification being implemented by whatever runtime Alfa is used in, which shouldn't really be a problem. It's of course readily available in browsers and is also supported in Node.js 10+ as well as Deno.