Account for presentational role conflict resolution in ARIA feature mappings #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasperisager
changed the title
kasperisager
previously requested changes
Jun 17, 2020
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
Co-authored-by: Kasper Isager <[email protected]>
kasperisager
added a commit
that referenced
this pull request
Jun 23, 2020
* master: Rewrite the CLI internals (#265) Avoid discarding rules when adding to `RuleTree` (#274) Move presentational role conflict resolution down to Role.from (#273) Support passing additional arguments to `Parser` Update README Rewrite the @siteimprove/alfa-math package (#268) Create security.md Treat kind attribute as enumerated (#269) Account for presentational role conflict resolution in ARIA feature mappings (#264) Update lockfile Prevent infinite instantiation of `Interview` type (#266) Lazy load syntax definitions (#263) Add user agent styles for `<noscript>` element (#260) Fix some parse issues in `Media` `Preference.initial()` -> `Preference.unset()` Add scripting and user preferences as `Device` parameters (#259) Give build scripts a once-over
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an
<img alt="" aria-label="foo" />, Presentational role conflict resolution triggered but returnsnoneagain as it is the implicit role withalt="".This should fix it.
Role aspect can now take optional arguments.