Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling upload errors in logging #120

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Handling upload errors in logging #120

wants to merge 3 commits into from

Conversation

Jym77
Copy link
Contributor

@Jym77 Jym77 commented Dec 20, 2024

WiP, handling errors a bit better in the console logging.

This gets a better error handling in the SIP.upload function, and does some error display in Logging.fromAudit. Thus, if an upload error is encountered, instead of silently discarding it (just having an err return value to the upload), we show it in the logging part. This should ease error detection and recovery for the SIP.upload().then(Logging#print) flows that act blindly. The errors are only printed at the warn level because it might be a normal flow, e.g. when running locally with missing credentials, …

TODO: add tests, include some simnilar error messaging for the .getUnsafe in Logging.fromAudit.

@Jym77 Jym77 self-assigned this Dec 20, 2024
Copy link

changeset-bot bot commented Dec 20, 2024

⚠️ No Changeset found

Latest commit: 5340eb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Jym77 Jym77 added the minor Backwards-compatible change that touches public API label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Backwards-compatible change that touches public API
Projects
Status: 🧑‍💻 Doing
Development

Successfully merging this pull request may close these issues.

1 participant