Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WiP, handling errors a bit better in the console logging.
This gets a better error handling in the
SIP.upload
function, and does some error display inLogging.fromAudit
. Thus, if an upload error is encountered, instead of silently discarding it (just having anerr
return value to the upload), we show it in the logging part. This should ease error detection and recovery for theSIP.upload().then(Logging#print)
flows that act blindly. The errors are only printed at the warn level because it might be a normal flow, e.g. when running locally with missing credentials, …TODO: add tests, include some simnilar error messaging for the
.getUnsafe
inLogging.fromAudit
.