Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Nextjs][Personalize] Don't resolve site in CdpPageView when it's disabled #1365

Merged
merged 2 commits into from
Mar 3, 2023
Merged

[Nextjs][Personalize] Don't resolve site in CdpPageView when it's disabled #1365

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ea463
[Nextjs][Personalize] Don't resolve site in CdpPageView when it's dis…
illiakovalenko Mar 3, 2023
3da2160
Simplify
illiakovalenko Mar 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/create-sitecore-jss/src/templates/nextjs-personalize/src/components/CdpPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const CdpPageView = (): JSX.Element => {
} = useSitecoreContext();

const siteName = site?.name || config.jssAppName;
const siteInfo = siteResolver.getByName(siteName);

/**
* Creates a page view event using the Sitecore Engage SDK.
Expand Down Expand Up @@ -72,10 +71,12 @@ const CdpPageView = (): JSX.Element => {
if (disabled()) {
return;
}

const siteInfo = siteResolver.getByName(siteName);
illiakovalenko marked this conversation as resolved.
Show resolved Hide resolved
const language = route.itemLanguage || config.defaultLanguage;
const pageVariantId = CdpHelper.getPageVariantId(route.itemId, language, variantId as string);
createPageView(route.name, language, siteInfo, pageVariantId);
}, [pageState, route, variantId, siteInfo]);
}, [pageState, route, variantId, siteName]);

return <></>;
};
Expand Down