Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Next] Exclude Image fill priority props from being added to EE markup #1346

Merged
merged 1 commit into from
Feb 17, 2023
Merged

[Next] Exclude Image fill priority props from being added to EE markup #1346

merged 1 commit into from
Feb 17, 2023

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Feb 17, 2023 •
edited
Loading

Description / Motivation

Excluded fill, priority props from the final EE markup, since regular img tag doesn't support that

Testing Details

Manual testing in EE

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team February 17, 2023 06:28
ambrauer
ambrauer approved these changes Feb 17, 2023
View reviewed changes
Copy link
Contributor

@ambrauer ambrauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ambrauer ambrauer merged commit f3b502d into dev Feb 17, 2023
@ambrauer ambrauer deleted the bugfix/573771 branch February 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ambrauer ambrauer ambrauer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @ambrauer