#559044: [SXA] fixed rendering dynamic placeholders for splitter components #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc-ruslanmatkovskyi
force-pushed
the
bugfix/559044-fix-dynamic-placeholder
branch
from
0cba88a
to
430dd60
Compare
StanislavStativa
approved these changes
Jan 16, 2023
illiakovalenko
requested changes
Jan 16, 2023
packages/sitecore-jss-react/src/components/PlaceholderCommon.tsx
Outdated
Show resolved
Hide resolved
sc-ruslanmatkovskyi
force-pushed
the
bugfix/559044-fix-dynamic-placeholder
branch
2 times, most recently
from
80aeb86
to
38f3747
Compare
illiakovalenko
pushed a commit
that referenced
this pull request
Jan 17, 2023
…rns for Splitter components
sc-ruslanmatkovskyi
force-pushed
the
bugfix/559044-fix-dynamic-placeholder
branch
from
38f3747
to
d7c3ef2
Compare
|
|
@matkovskyi Build is failed, please, fix issues first |
sc-ruslanmatkovskyi
force-pushed
the
bugfix/559044-fix-dynamic-placeholder
branch
from
ae9e6b2
to
29e6e17
Compare
fixed! thanks) |
illiakovalenko
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation
Added pattern and checking for rendering Dynamic placeholders.
There was bug with rendering splitter components with fix Dynamics placeholders.
Testing Details
Types of changes