Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[React]Upgrade 3rd party dependencies #1250

Merged
merged 8 commits into from
Dec 19, 2022
Merged

[React]Upgrade 3rd party dependencies #1250

merged 8 commits into from
Dec 19, 2022

Conversation

illiakovalenko
Copy link
Contributor

@illiakovalenko illiakovalenko commented Dec 1, 2022 •
edited
Loading

Description / Motivation

  • Upgrade sitecore-jss-react dependencies
  • Upgrade sitecore-jss-react-forms dependencies
  • Upgrade sitecore-jss-nextjs required dependencies to be compatible with new changes
  • Migration for samples/react

Testing Details

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@illiakovalenko illiakovalenko requested a review from a team December 1, 2022 11:51
addy-pathania
addy-pathania approved these changes Dec 16, 2022
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please resolve merge conflicts.

@illiakovalenko illiakovalenko merged commit 346311c into dev Dec 19, 2022
@illiakovalenko illiakovalenko deleted the feature/513285 branch December 19, 2022 09:18
addy-pathania
addy-pathania reviewed Dec 19, 2022
View reviewed changes
Copy link
Contributor

@addy-pathania addy-pathania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addy-pathania addy-pathania addy-pathania approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@illiakovalenko @addy-pathania